-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.8.0 #5733
Release 4.8.0 #5733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one exception that I'm not sure is cross-platform (though maybe it is?) and a couple of test failures. Otherwise, it looks good!
@@ -93,6 +93,9 @@ update-go-module: | |||
update-runtime-dafny: | |||
(cd "${DIR}"; cd Source/DafnyRuntime/DafnyRuntimeDafny; make update-go) | |||
|
|||
update-standard-libraries: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thing to add!
var exitCode = 1; | ||
try { | ||
exitCode = await operand.Execute(inputReader, outputWriter, errorWriter); | ||
} catch (Win32Exception) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this exception would be a different one on non-Windows platforms. Or is it used on all platforms in .NET?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows does not have the "rm" command so I'm not sure if the original returns an exception if the file does not exist or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the code was working fine in other platforms without the try catch, so I'm not expecting this to break any other platform.
EDIT: piping the result of @atomb LMK if this works for you |
… order + .doo files updated
Changes accepted. |
Description
Merging the release 4.8.0 branch into master It brings several modifications that were deemed necessary
%rm
won't fail if a file or a folder does not exist (which is the case the first time)-f
option to cp and mv to be able to run the same test multiple timesHow has this been tested?
Tests are passing on the CI and previously offending tests are also passing on my Windows machine.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.